Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove nw1 mode #7230

Open
rogerwang opened this issue Nov 22, 2019 · 9 comments
Open

Remove nw1 mode #7230

rogerwang opened this issue Nov 22, 2019 · 9 comments

Comments

@rogerwang
Copy link
Member

After nw2 mode released as default (#5875), it will get stablized in several major versions. Then the code for nw1 mode will be removed to save rebase effort. This issue is for tracking nw1 removal.
@rogerwang rogerwang pinned this issue Nov 22, 2019
@rogerwang
Copy link
Member Author

If anyone found their issue in nw2 and think it's blocking nw1 removal, please file an issue for nw2 and CC this issue.

@nvedamurthy nvedamurthy mentioned this issue Dec 6, 2019
Closed
This was referenced Dec 7, 2019
Closed
Closed
Closed
Closed
@rogerwang rogerwang mentioned this issue Dec 10, 2019
Closed
@nvedamurthy nvedamurthy mentioned this issue Dec 10, 2019
Closed
This was referenced Dec 15, 2019
Closed
Closed
This was referenced Dec 22, 2019
Closed
Closed
@rogerwang rogerwang mentioned this issue Dec 31, 2019
Closed
@Luzzifus Luzzifus mentioned this issue Jan 1, 2020
Closed
@rdtsc rdtsc mentioned this issue Jan 17, 2020
Closed
@DimPaDev DimPaDev mentioned this issue Jan 19, 2020
Closed
This was referenced Feb 6, 2020
Closed
Closed
@TheRealDannyyy TheRealDannyyy mentioned this issue Feb 10, 2020
Closed
This was referenced Feb 10, 2020
Closed
Closed
@TheRealDannyyy TheRealDannyyy mentioned this issue Feb 11, 2020
Closed
@arudnev arudnev mentioned this issue Feb 11, 2020
Closed
@TheRealDannyyy TheRealDannyyy mentioned this issue Feb 23, 2020
Open
@sysrage sysrage mentioned this issue Mar 15, 2020
Closed
This was referenced Mar 23, 2020
Closed
Closed
@Docteh Docteh mentioned this issue Apr 24, 2020
Closed
@anesuc anesuc mentioned this issue Apr 26, 2020
Closed
@djcanard djcanard mentioned this issue May 8, 2020
Closed
@djcanard
Copy link

djcanard commented May 9, 2020

@rogerwang any idea in what timeframe nw1 mode will be removed? Weeks, or months?

@rogerwang
Copy link
Member Author

There is only #7361 which might be blocking NW1 removal. I'd say after 1-2 major version updates.

@rogerwang rogerwang mentioned this issue May 13, 2020
Open
@TheRealDannyyy
Copy link

I think NW1 can be removed now.

My issue #7362 seems to be caused by Chrome's Win10 custom title bar implementation (which NW2 added support for).

@bastimeyer
Copy link

I think NW1 can be removed now.

There are still some issues like this one for example: #7488

@rogerwang rogerwang mentioned this issue Jun 10, 2020
Closed
@theDevelopper theDevelopper mentioned this issue Jul 13, 2020
Closed
@sysrage sysrage mentioned this issue Jul 16, 2020
Closed
@rogerwang rogerwang mentioned this issue Jul 16, 2020
Closed
@theDevelopper theDevelopper mentioned this issue Jul 17, 2020
Closed
@josh83abc josh83abc mentioned this issue Aug 30, 2020
Open
@josh83abc
Copy link

Issues with evalNWBin, I always disable NW2 in my app for now #7547

@escatg escatg mentioned this issue Sep 7, 2020
Closed
@josh83abc
Copy link

josh83abc commented Oct 10, 2020 •
edited

I just have added information Issues with evalNWBin #7547 but you closed it :'(

@rogerwang rogerwang mentioned this issue Oct 15, 2020
Closed
@DjulLau DjulLau mentioned this issue Oct 15, 2020
Closed
@rogerwang rogerwang mentioned this issue Oct 18, 2020
Open
@t-mish t-mish mentioned this issue Feb 27, 2021
Open
@peq42
Copy link

peq42 commented Dec 10, 2021

what is the current progress on the removal of NW1 mode @rogerwang ?

@bastimeyer bastimeyer mentioned this issue Nov 4, 2022
Closed
2 tasks
@ayushmanchhabra ayushmanchhabra mentioned this issue Nov 7, 2022
Open
3 tasks
@Sunvas
Copy link

Sunvas commented Dec 11, 2023

Any updates?

@malisipi malisipi mentioned this issue Dec 27, 2023
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@rogerwang @Sunvas @bastimeyer @djcanard @TheRealDannyyy @josh83abc @peq42