Add js variable to check if AAC is successful or not #7755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What work needs to be done for this to be merged. Someone need to do a test build? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original AAC PR: #7698
While testing AAC feature, I realized that it would be nice to have a variable whose value reflects the successful start of AAC instead of having to look into the logs. The purpose of this PR is to add such a variable.
More details about this pull request:
Example:
let x = nw.Window.get(window); x.enterKioskMode();
...
console.log(x.isAACActive); // It should return True if AAC starts and False otherwise.
Note: I have a hard time building it to fully test it but I hope that the code is okay and may be it can be tested from the build system's nightly build.