test: add crash-dump-report server demo of nodejs #7959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is #7940 related to this? |
|
No, this is just an example of a nwjs-crash-report-server implemented in js |
|
@rogerwang based on what I can see in the diff, this would be a nice addition to the sanity tests |
There was a problem hiding this comment.
Hi @ostli, please disregard my earlier comment. I have now become more familiar with NW.js codebase. Sanity tests are automated via Chromedriver. If the test does not fit under sanity, I'd suggest adding it under manual.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.