Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Stop Sharing" button is missing #8156

Open
2 of 3 tasks
shikhak opened this issue Jan 4, 2024 · 4 comments
Open
2 of 3 tasks

"Stop Sharing" button is missing #8156

shikhak opened this issue Jan 4, 2024 · 4 comments
Labels
bug has-min-repro Has a minimum reproduction

Comments

@shikhak
Copy link

shikhak commented Jan 4, 2024 •
edited

Issue Type

Before opening an issue, please search and see if it has already been raised.

  • Bug Report

  • Feature Request

  • Successfully reproduced against the latest version of NW.js?
    ExpectedResults

Current/Missing Behavior

"Stop sharing " button is missing while sharing screen via webrtc site.

Expected/Proposed Behavior

"Stop sharing" button should be visible and user should be able to stop the screen sharing.

Additional Info

- Crash report:
@sysrage
Copy link

sysrage commented Jan 4, 2024

I have also reproduced this in Windows 10.

@ayushmanchhabra ayushmanchhabra added bug has-min-repro Has a minimum reproduction labels Jan 17, 2024
@shikhak
Copy link
Author

shikhak commented Jan 17, 2024 •
edited

@ayushmanchhabra Shared this patch with me https://github.com/nwutils/nw-patches/blob/43b75a657fd877594d548a281cd02bc486a897d3/patches/chromium.patch#L8129-8206

By un-doing the following changes Stop sharing button is visible and working as expected:
X_is_sharing_your_screen

File 1 :
Undo all the changes in file : nw/chromium/chrome/browser/media/webrtc/desktop_capture_devices_util.cc

File 2:
nw/chromium/chrome/browser/media/webrtc/desktop_capture_access_handler.cc

Only remove this change "extension->is_nwjs_app() ||" at two places (line no : 8098, 8106)

@sysrage
Copy link

sysrage commented Jan 17, 2024

@rogerwang please take a look and revert these changes unless they're needed for some reason.

@shikhak shikhak mentioned this issue Jan 17, 2024
Open
@shikhak
Copy link
Author

shikhak commented Jan 17, 2024

PR : https://github.com/nwjs/chromium.src/pull/165/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug has-min-repro Has a minimum reproduction
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sysrage @shikhak @ayushmanchhabra