Revert "[test] use shell=True to launch python3 http server"

This reverts commit 0fb96d4.
nwjs · Apr 20, 2024 · efe1d07 · efe1d07
1 parent 2f59c05
commit efe1d07
Show file tree

Hide file tree

Showing 19 changed files with 19 additions and 19 deletions.
diff --git a/test/sanity/additional_trust_anchors/test.py b/test/sanity/additional_trust_anchors/test.py
@@ -18,7 +18,7 @@
 os.chdir(testdir)
 
 port = str(utils.free_port())
-server = subprocess.Popen(['python3', 'https-server.py', port], shell=True)
+server = subprocess.Popen(['python3', 'https-server.py', port])
 
 def read_ca_cert():
     return read_and_replace_file('ca.crt', '\n', '')

diff --git a/test/sanity/app-open-event/test.py b/test/sanity/app-open-event/test.py
@@ -18,7 +18,7 @@
 driver = webdriver.Chrome(executable_path=os.environ['CHROMEDRIVER'], chrome_options=chrome_options, service_log_path="log", service_args=["--verbose"])
 try:
     print((driver.current_url))
-    second_instance = subprocess.Popen(['python3', 'second_instance.py'], shell=True)
+    second_instance = subprocess.Popen(['python3', 'second_instance.py'])
     result = wait_for_element_id_content(driver, 'result', 'success')
     print(result)
 finally:

diff --git a/test/sanity/iframe-remote-neg/test.py b/test/sanity/iframe-remote-neg/test.py
@@ -16,7 +16,7 @@
 os.chdir(testdir)
 
 port = str(utils.free_port())
-server = subprocess.Popen(['python3', 'http-server.py', port], shell=True)
+server = subprocess.Popen(['python3', 'http-server.py', port])
 
 html = open('index.html', 'w')
 html.write('''

diff --git a/test/sanity/iframe-remote/test.py b/test/sanity/iframe-remote/test.py
@@ -16,7 +16,7 @@
 os.chdir(testdir)
 
 port = str(utils.free_port())
-server = subprocess.Popen(['python3', 'http-server.py', port], shell=True)
+server = subprocess.Popen(['python3', 'http-server.py', port])
 
 html = open('index.html', 'w')
 html.write('''

diff --git a/test/sanity/issue4096-download/test.py b/test/sanity/issue4096-download/test.py
@@ -19,7 +19,7 @@
 os.chdir(testdir)
 
 port = str(utils.free_port())
-server = subprocess.Popen(['python3', 'http-server.py', port], shell=True)
+server = subprocess.Popen(['python3', 'http-server.py', port])
 
 html = open('index.html', 'w')
 html.write('''

diff --git a/test/sanity/issue4130-win-open-close-fail-http/test.py b/test/sanity/issue4130-win-open-close-fail-http/test.py
@@ -17,7 +17,7 @@
 os.chdir(testdir)
 
 port = str(utils.free_port())
-server = subprocess.Popen(['python3', 'http-server.py', port], shell=True)
+server = subprocess.Popen(['python3', 'http-server.py', port])
 
 tpl = open('index.tpl', 'r')
 content = tpl.read().replace('{port}', port)

diff --git a/test/sanity/issue4143-chrome-sockets-permission/test.py b/test/sanity/issue4143-chrome-sockets-permission/test.py
@@ -14,7 +14,7 @@
 os.chdir(testdir)
 
 port = str(utils.free_port())
-server = subprocess.Popen(['python3', 'http-server.py', port], shell=True)
+server = subprocess.Popen(['python3', 'http-server.py', port])
 
 tpl = open('index.tpl', 'r')
 content = tpl.read().replace('{port}', port)

diff --git a/test/sanity/issue4180-remote-win-open/test.py b/test/sanity/issue4180-remote-win-open/test.py
@@ -14,7 +14,7 @@
 os.chdir(testdir)
 
 port = str(utils.free_port())
-server = subprocess.Popen(['python3', 'http-server.py', port], shell=True)
+server = subprocess.Popen(['python3', 'http-server.py', port])
 
 tpl = open('index.tpl', 'r')
 content = tpl.read().replace('{port}', port)

diff --git a/test/sanity/issue4184-no-opener/test.py b/test/sanity/issue4184-no-opener/test.py
@@ -17,7 +17,7 @@
 os.chdir(testdir)
 
 port = str(utils.free_port())
-server = subprocess.Popen(['python3', 'https-server.py', port], shell=True)
+server = subprocess.Popen(['python3', 'https-server.py', port])
 
 tpl = open('index.tpl', 'r')
 content = tpl.read().replace('{port}', port)

diff --git a/test/sanity/issue4269-click-link-crash/test.py b/test/sanity/issue4269-click-link-crash/test.py
@@ -16,7 +16,7 @@
 os.chdir(testdir)
 
 port = str(utils.free_port())
-server = subprocess.Popen(['python3', 'http-server.py', port], shell=True)
+server = subprocess.Popen(['python3', 'http-server.py', port])
 
 tpl = open('inspect.tpl', 'r')
 content = tpl.read().replace('{port}', port)

diff --git a/test/sanity/issue4788-openremote-cdtopen/test.py b/test/sanity/issue4788-openremote-cdtopen/test.py
@@ -19,7 +19,7 @@
 os.chdir(testdir)
 
 port = str(utils.free_port())
-server = subprocess.Popen(['python3', 'http-server.py', port], shell=True)
+server = subprocess.Popen(['python3', 'http-server.py', port])
 
 html = open('index.html', 'w')
 html.write('''

diff --git a/test/sanity/issue5781-X-Frame-Options/test.py b/test/sanity/issue5781-X-Frame-Options/test.py
@@ -16,7 +16,7 @@
 os.chdir(testdir)
 
 port = str(utils.free_port())
-server = subprocess.Popen(['python3', 'http-server.py', port], shell=True)
+server = subprocess.Popen(['python3', 'http-server.py', port])
 
 tpl = open('index.tpl', 'r')
 content = tpl.read().replace('{port}', port)

diff --git a/test/sanity/issue6099-AdSense-trouble/test.py b/test/sanity/issue6099-AdSense-trouble/test.py
@@ -16,7 +16,7 @@
 os.chdir(testdir)
 
 port = str(utils.free_port())
-server = subprocess.Popen(['python3', 'http-server.py', port], shell=True)
+server = subprocess.Popen(['python3', 'http-server.py', port])
 
 tpl = open('index.tpl', 'r')
 content = tpl.read().replace('{port}', port)

diff --git a/test/sanity/issue7305-nwfaketop-cookie-neg/test.py b/test/sanity/issue7305-nwfaketop-cookie-neg/test.py
@@ -21,7 +21,7 @@
     pass
 
 port = str(utils.free_port())
-server = subprocess.Popen(['python3', 'https-server.py', port], shell=True)
+server = subprocess.Popen(['python3', 'https-server.py', port])
 
 tpl = open('index.tpl', 'r')
 content = tpl.read().replace('{port}', port)

diff --git a/test/sanity/node-remote-array/test.py b/test/sanity/node-remote-array/test.py
@@ -14,7 +14,7 @@
 os.chdir(testdir)
 
 port = str(utils.free_port())
-server = subprocess.Popen(['python3', 'http-server.py', port], shell=True)
+server = subprocess.Popen(['python3', 'http-server.py', port])
 
 manifest = open('package.json', 'w')
 manifest.write('''

diff --git a/test/sanity/node-remote-negtive/test.py b/test/sanity/node-remote-negtive/test.py
@@ -16,7 +16,7 @@
 os.chdir(testdir)
 
 port = str(utils.free_port())
-server = subprocess.Popen(['python3', 'http-server.py', port], shell=True)
+server = subprocess.Popen(['python3', 'http-server.py', port])
 
 manifest = open('package.json', 'w')
 manifest.write('''

diff --git a/test/sanity/node-remote/test.py b/test/sanity/node-remote/test.py
@@ -13,7 +13,7 @@
 os.chdir(testdir)
 
 port = str(utils.free_port())
-server = subprocess.Popen(['python3', 'http-server.py', port], shell=True)
+server = subprocess.Popen(['python3', 'http-server.py', port])
 
 manifest = open('package.json', 'w')
 manifest.write('''

diff --git a/test/sanity/open-remote/test.py b/test/sanity/open-remote/test.py
@@ -18,7 +18,7 @@
 os.chdir(testdir)
 
 port = str(utils.free_port())
-server = subprocess.Popen(['python3', 'http-server.py', port], shell=True)
+server = subprocess.Popen(['python3', 'http-server.py', port])
 
 html = open('index.html', 'w')
 html.write('''

diff --git a/test/sanity/user-agent/test.py b/test/sanity/user-agent/test.py
@@ -10,7 +10,7 @@
 testdir = os.path.dirname(os.path.abspath(__file__))
 os.chdir(testdir)
 
-server = subprocess.Popen(['python3', '-u', 'echo-user-agent.py'], stdout=subprocess.PIPE, stderr=subprocess.PIPE, shell=True)
+server = subprocess.Popen(['python3', '-u', 'echo-user-agent.py'], stdout=subprocess.PIPE, stderr=subprocess.PIPE)
 print(server.stdout.readline())
 
 driver = webdriver.Chrome(executable_path=os.environ['CHROMEDRIVER'], chrome_options=chrome_options)